fix(calcite-filter): added rtl check and updated styles

Esri / calcite-app-components

A collection of calcite components for building single page applications

https://esri.github.io/calcite-app-components/

Other

39 stars 10 forks source link

fix(calcite-filter): added rtl check and updated styles #966

Closed asangma closed 4 years ago

asangma commented 4 years ago

Related Issue: #959

Summary

Added an RTL check to CalciteFilter.
Added and updated styles accordingly
- style linting asked for some rearrangement
updated demo app to include filtering in pick-list in RTL

@driskull I can't figure out how to get CalciteFilter to see an upstream dir="rtl".

cc @AdelheidF

asangma commented 4 years ago

@jcfranco Sorry...thought you had worked on this.

asangma commented 4 years ago

@driskull @jcfranco Could either of you help me with the getElementDirection. It looks like it would need to come through PickList, but it may need to be added to List?

driskull commented 4 years ago

@asangma yeah I can help. Maybe we just need to set a dir attribute somewhere?

asangma commented 4 years ago

@driskull I think it's about getting Filter to see if dir is set on PickList or List..?

driskull commented 4 years ago

Checked in update @asangma. Let me know if that works for you.

asangma commented 4 years ago

Thanks @driskull...checking.

asangma commented 4 years ago

Sweet! Thanks.