Enhancement: ActionPad. Add horizontal orientation

Esri / calcite-app-components

A collection of calcite components for building single page applications

https://esri.github.io/calcite-app-components/

Other

39 stars 10 forks source link

Closed asangma closed 4 years ago

asangma commented 4 years ago

Add a property that will allow users to set the orientation of the ActionPad to horizontal.

| vs –

ActionPad and ActionGroup

Toolbars for table editing or chart configuring.

cc @driskull

driskull commented 4 years ago

Would this ever make it to the action-bar?

driskull commented 4 years ago

@asangma @jcfranco can you help name this property?

We could go with:

layout of horizontal/vertical but we already have a deprecated layout property so this would be a breaking change.
orientation of portrait/landscape or horizontal/vertical?
direction of row/column or horizontal/vertical. May sound too similar to dir attribute?

My vote would be toward layout or direction

jcfranco commented 4 years ago

I like layout and it's also the consistent option.

driskull commented 4 years ago

Ok cool. We can talk about it at the next meeting. I could remove all deprecated things and we would be at V 6.0

driskull commented 4 years ago

Decision was to use layout, remove all deprecations, and do a major release.

kat10140 commented 4 years ago

verf!