search

Esri / calcite-bootstrap

A Calcite theme and a custom build system for building Bootstrap apps.
http://esri.github.io/calcite-bootstrap/
Apache License 2.0
48 stars 29 forks source link

Calcite-Bootstrap should also support Dojo-Bootstrap #149

Closed alaframboise closed 9 years ago

alaframboise commented 9 years ago

Today, developers have the choice of using Bootstrap with jQuery or dojo + Dojo-Bootstrap to build sites. Therefore, we should ensure Calcite-Bootstrap also works with both JS environments.

The main reasons are:

  1. Every ArcGIS JS app loads dojo and there's no reason to load jQuery too.
  2. Devs generally don't like combining jQuery and dojo.

The good news is that pure Calcite-Bootstrap should just work with Dojo-Bootstrap. I've actually built a number of Bootstrap-map-js dojo demos that use this library and it works as expected.

We just need to do some testing to make sure this framework works too.

image

alaframboise commented 9 years ago

I just did a quick pass but here is an example that is pure dojo using calcite-bootstrap and calcite-maps. Was pretty painless!

https://github.com/ArcGIS/calcite-maps/blob/master/arcgis-dojo.html

Live Demo

dbouwman commented 9 years ago

@alaframboise can we close this now? if not, is there some other test or validation you'd like to see?

alaframboise commented 9 years ago

As long as we don't change the underlying bootstrap.js for any calcite-specific functionality, the dojobootstrap libraries will continue to work. That said, I think it would be good to have some doc and potentially a sample that shows calcite-bootstrap devs how to load the dojobootstrap.js libraries with require - just like I did in calcite-maps.

alaframboise commented 9 years ago

Actually, once we firm-up calcite-maps, we should add links in the calcite-bootstrap reference. We should brainstorm to see how this should all be linked together. I know @CassidyB wanted me to also doc calcite-map app dev patterns...

TheBlueDog commented 9 years ago

There are no plans to change/modify the js that comes with core bootstrap.

TheBlueDog commented 9 years ago

Closing this as the actionable task is now issue #174