Default font-weight too light for calcite-bootstrap-open

Esri / calcite-bootstrap

A Calcite theme and a custom build system for building Bootstrap apps.

http://esri.github.io/calcite-bootstrap/

Apache License 2.0

48 stars 29 forks source link

Default font-weight too light for calcite-bootstrap-open #186

Closed alaframboise closed 9 years ago

alaframboise commented 9 years ago

It looks like we default to font-weight: 300 for calcite-bootstrap-open. I know it works for fast-fonts Avenir but this might be a shade light for the open defaults (see image). Maybe this would work better?

font-weight: none or font-weight: 400

TheBlueDog commented 9 years ago

If you're pulling in the *-open.css you should see Avenir at all.

alaframboise commented 9 years ago

Right, I removed the Avenir references and saw some improved results, but Helvetica is pretty thin and choppy at 300 so I just want to make sure font-family: Helvetica and font-weight: 300 is still what we want to default to on body. If so, I'll have to change font-size in a number of places.

Are there any open font options that render a little sharper?

TheBlueDog commented 9 years ago

Is Open Sans not working for you? Really there's no reason you should be falling back to Helvetica.

alaframboise commented 9 years ago

Ok, I see now. You put Open Sans in /assets and it's not in calcite-bootstrap-open.css. I guess I was expecting calcite-bootstrap-open.css to have body { font-family: "Open Sans", ... }. Not a problem, I just added it to the body. It would be good to doc this.

I wouldn't say it's as good as Avenir but it's better than Helvetica.

TheBlueDog commented 9 years ago

This issue uncovered a bug in the builds that is causing the primary typefaces to be dropped. Issue #187 will addresses this.