search

Esri / calcite-bootstrap

A Calcite theme and a custom build system for building Bootstrap apps.
http://esri.github.io/calcite-bootstrap/
Apache License 2.0
48 stars 29 forks source link

Consider using calcite-colors instead of defining them in our Sass #225

Open alaframboise opened 8 years ago

alaframboise commented 8 years ago

We re-define the calcite-colors in our Sass. It might make more sense to pull in the calcite-colors repo and borrow those color vars as they could change in the future and it might be more maintainable. We could do the same with calcite-icons when it is ready.

Thoughts?

@TheBlueDog

CassidyB commented 8 years ago

We will need to work to figure this out more in detail soon. I have Nik coming down this month to start talking about how to better tie Bootstrap to the core Calcite Web repo so we can maintain less code.

TheBlueDog commented 8 years ago

Just as long as it doesn't break Calcite Bootstrap from being used stand-alone. You shouldn't have to install Calcite Bootstrap and then Calcite Colors to make it work.

CassidyB commented 8 years ago

Agreed, and yes, that is not the goal. The goal would be that we can build a new version that is standalone when we update Calcite Web code.