search

Esri / calcite-bootstrap

A Calcite theme and a custom build system for building Bootstrap apps.
http://esri.github.io/calcite-bootstrap/
Apache License 2.0
48 stars 29 forks source link

Calcite-Bootstrap nav-toggle collapses left, default bootstrap collapses right #90

Closed alaframboise closed 9 years ago

alaframboise commented 9 years ago

Is our nav-toggle supposed to behave like bootstrap (collapse right) or calcite (collapse left)?

If we have the choice, I would keep the nav on the right as it will be more in line with default bootstrap and easier to convert apps over.

Bootstrap image

Calcite-Bootstrap image

TheBlueDog commented 9 years ago

Moving it to the left was based on the work being done on Calcite-Web. There, it's on the left.

screen shot 2015-07-31 at 2 56 43 pm

Though, right now we are using the standard bootstrap dropdown pattern and Calcite-Web is using a drawer. We'll need to decide if Bootstrap need to match or not.

screen shot 2015-07-31 at 2 56 46 pm

/cc @CassidyB

TheBlueDog commented 9 years ago

For this issue at least, I've reduced the margin on the right of the button when in collapsed mode so it doesn't look too spaced out.

Before:

screen shot 2015-07-31 at 2 59 53 pm

After:

screen shot 2015-07-31 at 2 59 39 pm

alaframboise commented 9 years ago

Just as a side note, from a mobile ux standpoint, I believe menus on the right are slightly more accessible.

http://ux.stackexchange.com/questions/45110/hamburger-menu-icons-should-they-be-on-the-left-or-right

TheBlueDog commented 9 years ago

I think this will be dependent on the navigation pattern we use. If we stick with standard bootstrap, it could go left or right and the UI won't seem broken. If we use the slide-in drawer, then it should go on the side the drawer is.