Esri / calcite-colors

Esri's official color documentation repository that is leveraged by Calcite and all other Esri initiatives.
https://esri.github.io/calcite-colors/
Other
26 stars 6 forks source link

Proposal for new ui-blue-hover-dark variable. #37

Closed bstifle closed 4 years ago

bstifle commented 4 years ago

@julio8a @kyle-03674 @macandcheese

proposing that we change the hex value of ui-blue-hover-dark

from #59D6FF to #67C7FF due to the slight green hue in the prior.

blue-hover-update-proposal

kyle-03674 commented 4 years ago

If $v-bb-120 were to change to #67C7FF then the that color would be much less vibrant, and not match the rest of the vibrant 120 colors. Attached is a (jumbled mess) of nearby colors in that set. I’m not disagreeing that the current color is a bit green - just that it’s worth it in order to keep the same vibrant feel across the board. Many of the vibrant colors have hue shifts in order to favor high saturation. [cid:3B8A8A09-FF38-47CD-BED5-DD8E5773FD09@esri.com]

bstifle commented 4 years ago

@kyle-03674 what image are you showing? didnt come through

kyle-03674 commented 4 years ago

trying again - this time through web interface instead of email response image

bstifle commented 4 years ago

VV seems to share the same problem. the current v-bb-120 feels like it belongs in between bg and bb

kyle-03674 commented 4 years ago

right. That's by design - to favor saturation over hue stability in this range. (The feedback on my earlier Vibrant drafts, from Jay and others, was that they weren't really vibrant.) The intent of the vibrant set was to be use as accents only - sparingly. So if it only appears for a short time, maybe it's not an issue.

bstifle commented 4 years ago

@julio8a based on this we may just need to develop an actual dark theme for ui-variables.

bstifle commented 4 years ago

^instead of using vibrants

bstifle commented 4 years ago

hmm the more i think about it. the more i think the strategy to hue shift only on certain levels is the wrong choice. @kyle-03674 it's odd that only the first (120) has a green hue shift. it seems pretty inconsistent, hence the origins of this request.

kyle-03674 commented 4 years ago

the light-bright colors - aka the 120 range - is the area that needed the most adjustment to be both highly saturated and light. The medium and dark ranges are naturally easy to be saturated because there's more color there to work with. GG and RR also have hue shifts. Lemme think about this some more...

bstifle commented 4 years ago

ok cool. I see the issue, but its' tough since there aren't any other colors that are this light and this saturated that can be used for logical color shifts like button states.

looking forward to see what youre working through

kyle-03674 commented 4 years ago

true true - maybe we need a "UI Selection Set". I, too, was trying to find similar colors in the H range, and there's nothing like it. We used to have set just for UI colors. Is blue the only selection color needed? (please say yes). If we go the route of a new UI Selection range - or whatever it's called, I think you should establish the ranges and the colors you need, and then I'd like to review that.

@julio8a and @bstifle does that make sense to you? I could see other platforms using this as well. What's your take.

bstifle commented 4 years ago

blue yellow red and green.... so yeah the colors you said shifted haha.

the vibrants work well for dark theme ui selections. except for the 120s

@kyle-03674

kyle-03674 commented 4 years ago

@bstifle how soon do you want to resolve this?

kyle-03674 commented 4 years ago

And is there a way to see if any of the v-xx-120 variables are being used anywhere on esri.com or other sites?

bstifle commented 4 years ago

asap would be amazing. working on an exportable color palette for ui-web colors

they arent being used yet. we are in the beginning stages. calcite will most likely be the first big adopter

kyle-03674 commented 4 years ago

the more I look at it, when i cover up with my thumb the proposed color.... I like the original v-bb-120 better...I think that's fine, and working well, actually. I don't think the hue need to match for this to be successful.

bstifle commented 4 years ago

i disagree. blue is such an important and core color for all of the interfaces. on light theme, the hue never shifts for hover states or selected or pressed states. Since we are relying on vibrant for dark theme (which seem to be working well), this color is the outlier.

do we need to just work together to make a different set that is for dark theme? that may be the compromise

kyle-03674 commented 4 years ago

I think so. I'm also thinking about the non-UI needs of this color set. Putting that aside… why don't you select the blue colors that would be ideal for your needs - plan that out - and then let’s look at it. Maybe you’ve had to compromise some because there’s not many color choices available. Or maybe accessibility could be better if you were able to tweak the colors… now’s your chance with this new set :) … I’m keeping an open mind that maybe once you get into it, you find it’s better to make a UI blue light and a UI blue dark sets.

bstifle commented 4 years ago

totally makes sense. ill do some fiddlin'. thanks man!

paulcpederson commented 4 years ago

@bstifle did you address this just now in #42 ?

bstifle commented 4 years ago

yes this was handled many moons ago @paulcpederson

paulcpederson commented 4 years ago

🌚 🌝