Closed bstifle closed 4 years ago
@bstifle nice start. I like where that's going. 1 - can you show me the light theme equivalent for comparison? 2 - the red pressed state, when compared to the other pressed states, is less saturated - do you want make it a bit lighter/brighter?
@kyle-03674 pressed red needs to be lighter. any more saturation and we are getting too dark. red is tricky on dark backgrounds
note that light and dark theme button states are different (inverted). eg. how pressed is light on dark theme, and hover is darker than default on dark theme
@bstifle right - makes sense to go lighter for pressed on dark theme. I was suggesting/asking if your red pressed dark theme color should be even lighter to be more similar to the other hues. like this
and thanks for the comparison :) i think these new dark theme colors feel right in line with light theme
hmm yeah! @kyle-03674 i could go for that on the pressed. @macandcheese @julio8a what do you think?
looks good to me!
I like it!
Thanks Kyle!
Cool, @bstifle should we update the dark pressed red to the hex @kyle-03674 is using in this pull request, or should me merge and open a new one?
@paulcpederson @julio8a @macandcheese @kyle-03674
I updated and pushed a new commit for the pressed red #FF7465. should be ready to go!
@bstifle, first PR!
noob status: confirmed!
Updated dark theme colors to new colors. Including the dark theme background and foreground