search

Esri / calcite-colors

Esri's official color documentation repository that is leveraged by Calcite and all other Esri initiatives.
https://esri.github.io/calcite-colors/
Other
26 stars 6 forks source link

Adjust nomenclature and values of bg/surface/text variables #39

Closed macandcheese closed 4 years ago

macandcheese commented 4 years ago

Breakout from discussion in https://github.com/Esri/calcite-colors/pull/38

Propose renaming "ui-foreground" which has been used for "text" to "ui-surface", keeping "ui-background", and adding "ui-text" color variables.

ui-background: $blk-005 ui-background-dark: $blk-210

ui-surface: $blk-000 ui-surface-hover: $blk-010 ui-surface-pressed: $blk-020

ui-surface-dark: $blk-200 ui-surface-dark-hover: $blk-210 ui-surface-dark-pressed: $blk-220

ui-text-primary: $blk-160 ui-text-secondary:$blk-180 ui-text-tertiary: $blk-200

ui-text-primary-dark: $blk-060 ui-text-secondary-dark:$blk-040 ui-text-tertiary-dark: $blk-020

Open to more prescriptive text titles like "header", "body", "subheader" (but they may not always be used in that order), and changes to above values, but I think this helps clarify the use case for these a bit more.

@bstifle @julio8a @paulcpederson @kyle-03674

julio8a commented 4 years ago

@macandcheese, can we close this one out?

We did use, background, foreground, text, etc