search

Esri / calcite-colors

Esri's official color documentation repository that is leveraged by Calcite and all other Esri initiatives.
https://esri.github.io/calcite-colors/
Other
26 stars 6 forks source link

Changed idle hover and press variables to 1, 2, and 3 #45

Closed bstifle closed 4 years ago

bstifle commented 4 years ago

Changed idle hover and press variables to 1, 2, and 3

paulcpederson commented 4 years ago

if we did semver we'd be at like 24.0.0

macandcheese commented 4 years ago

if we did semver we'd be at like 24.0.0

Yeah, I think these are good nomenclature changes to make but.. this is... pretty poor DX, we need better ways to communicate these changes when they occur, and should probably begin to use major version numbers for breaking changes like this.

macandcheese commented 4 years ago

It looks like there are also some conflicts that should be cleaned up 🧹🧹.

bstifle commented 4 years ago

@macandcheese which conflicts please advise thank you

julio8a commented 4 years ago

@paulcpederson, good point. We'll regroup on this repo and any other updates we want to make and add all this to a 2.0.

bstifle commented 4 years ago

@macandcheese @julio8a @paulcpederson

conflicts resolved, ready for another review

julio8a commented 4 years ago

Posted the change in the Calcite team on Microsoft Teams, waiting for some feedback.

julio8a commented 4 years ago

We should merge this one in

julio8a commented 4 years ago

merging