search

Esri / calcite-colors

Esri's official color documentation repository that is leveraged by Calcite and all other Esri initiatives.
https://esri.github.io/calcite-colors/
Other
27 stars 7 forks source link

feat!: Generate the SCSS file from the TS file #58 #65

Closed driskull closed 3 years ago

driskull commented 3 years ago

feat: Generate the SCSS file from the TS file #58

driskull commented 3 years ago

@jcfranco I'm done making changes. Do you think you could review?

I think we can get this in and then move the code to the new repo. What do you think?

driskull commented 3 years ago

If we don't want the breaking changes I can make the name part optional for the theme and not place light in the variable. I just thought it should be consistent with the dark ones.

paulcpederson commented 3 years ago

If we don't want the breaking changes I can make the name part optional for the theme and not place light in the variable. I just thought it should be consistent with the dark ones.

This might be a good idea for now.

driskull commented 3 years ago

Actually, the previous PR https://github.com/Esri/calcite-colors/pull/63 already has breaking changes so I think its ok to proceed with these renames.