search

Esri / calcite-colors

Esri's official color documentation repository that is leveraged by Calcite and all other Esri initiatives.
https://esri.github.io/calcite-colors/
Other
27 stars 7 forks source link

feat: Remove border conflicts with bg's, update Sass vars hex values #71

Closed caripizza closed 3 years ago

caripizza commented 3 years ago

Related issue: #68

Summary: This pr updates the following Sass var values for light/dark theme borders:

Sass var theme changes OLD NEW
Light theme    
  $ui-border-2-light: #dfdfdf (blk-030) #d4d4d4 (blk-040)
  $ui-border-3-light: #eaeaea (blk-020) #dfdfdf (blk-030)
Dark theme    
  $ui-border-1-dark: #4a4a4a (blk-170) #555555 (blk-160)
  $ui-border-2-dark: #404040 (blk-180) #4a4a4a (blk-170)
  $ui-border-3-dark: #353535 (blk-190) #404040 (blk-180)

(I tested these changes via npm link with my local cc clone, and they looked good to me/no major changes that I could see.)

Note: I wasn't sure if I should bump the patch version in package-lock/package.json. I can add that if that'd be helpful for release.