search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
289 stars 76 forks source link

why time-picker lacks change event? #10102

Open oldoldman opened 2 months ago

oldoldman commented 2 months ago

Check existing issues

Description

Hi, I found that calcite-time-picker will not raise any event when the value has changed while calcite-date-picker will raise change event which I think is very useful. Is there any plan for this? Many thanks!

Acceptance Criteria

add change event

Relevant Info

No response

Which Component

calcite-time-picker

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

Esri team

N/A

tristan-morrison commented 1 week ago

Bumping this.

Additional explanation

The calcite-time-picker is an external/documented component, but it has no documented events. Its counterpart, calcite-date-picker, has two documented events to indicate when the value changes. However, the event that calcite-time-picker uses to signal changes to its value is not documented.

https://github.com/Esri/calcite-design-system/blob/7cdb7aaa1b7b176fc6ad88111db473774eb0d5e3/packages/calcite-components/src/components/time-picker/time-picker.tsx#L202-L205

Is this lack of a change event on calcite-time-picker intentional? If so, what is the recommend mode of observing/reacting to changes in the time picker's value?