Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
281 stars 77 forks source link

Fix blocked issues action regex #10132

Closed DitwanP closed 3 weeks ago

DitwanP commented 3 weeks ago

Priority impact

p - low

Summary

The regex in action is not correctly matching for the "Blocked Issues:" part of the comment. Instead its just matching any mention of a number preceded by a #.

This is causing the action to run and fail on issues that don't actually have any blocked issues listed like this one https://github.com/Esri/calcite-design-system/issues/7748.

Here's the failed attempt: https://github.com/Esri/calcite-design-system/actions/runs/10477994663/job/29020354524

Desired Outcome

The action should correctly exit with the comment that there are no blocked issues listed on a closed issue.

Resources

No response

github-actions[bot] commented 3 weeks ago

Installed and assigned for verification.

github-actions[bot] commented 3 weeks ago

Issue #10119 has been closed, this issue is ready for re-evaluation.

cc @geospatialem,@DitwanP

DitwanP commented 3 weeks ago

🍠 Verified the issue was resolved and automation is still working as expected (see the bot comment above). Also checked that there was no comment on an issue that I intentionally listed without "Blocked issues: " in front of it.

Also also...

Screenshot 2024-05-21 at 11 06 30 AM