Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
285 stars 76 forks source link

[Input-Date-Picker] valueAsDate array value not handled by watcher #10291

Open maxpatiiuk opened 2 weeks ago

maxpatiiuk commented 2 weeks ago

Check existing issues

Actual Behavior

The type of valueAsDate is Date | Date[].

However, the watcher here has wrong type:

https://github.com/Esri/calcite-design-system/blob/791fd782ac275c27e7a32b37b62e9c48b4a18f42/packages/calcite-components/src/components/input-date-picker/input-date-picker.tsx#L189-L190

this.datePickerActiveDate has type Date, so assigning Date[] to is is an error

Expected Behavior

Update the watcher to handle the Date | Date[] property type

Reproduction Sample

-

Reproduction Steps

-

Reproduction Version

2.13.0-next.9

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

Esri team

ArcGIS Maps SDK for JavaScript

jcfranco commented 2 weeks ago

Possibly handled by https://github.com/Esri/calcite-design-system/pull/8402. cc @anveshmekala

anveshmekala commented 1 week ago

Possibly handled by #8402. cc @anveshmekala

Handled here