Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
289 stars 76 forks source link

BUG-000170584 "layers-f" icon is not visible in Calcite Design System and getting a "layers16F is not a valid calcite-ui-icon name" error. #10312

Closed geospatialem closed 1 month ago

geospatialem commented 1 month ago
"layers-f" icon is not visible in Calcite Design System and getting a "layers16F is not a valid calcite-ui-icon name" error.

Salesforce ID: BUG-000170584
Salesforce Submitter: Shlok Wagle
Salesforce Submit Date: 9/09/2024 3:29 PM
Salesforce Bug Type: Failure/Error
Salesforce Severity: Medium
Steps to Repro:

Steps to Reproduce:

  1. Go to the following documentation for svg icons provided by Calcite Design Systems.
  2. This particular link will show the "layers-f" icon. You will notice that this icon is not visible. https://developers.arcgis.com/calcite-design-system/icons/?icon=layers-f&query=layers-f
  3. Open dev tools > console. You will see a "layers16F" is not a valid calcite-ui-icon name error.
  4. If you click on other icons, they are visible. There only seems to be an issue with the "layers-f" icon.
  5. Tested by trying to add the same icon in a sample ArcGIS Maps SDK for JavaScript application and seeing a similar behavior.


Other Information:


Customer Data Specific Bug:

No


Repro Environment Details:

The layers-f icon in Calcite design system does not appear in a sample app or in the documentation icon sample.


Sample Environment Access Information:

https://developers.arcgis.com/calcite-design-system/icons/?icon=layers-f&query=layers-f


Development/PSIRT request?

No


Attached Files: No

Attached Video: No

Attached Logs: No

Attached Data: Yes

Reproducible in Latest Version: Yes


Repro Data: (n/a)
Work Around: (n/a)
Product: Calcite Design System
Functional Category: Calcite Design System
Client Platform: (n/a)
Version Found: 2.11.0
Planned Version Fixed: (n/a)
Comment: (n/a)

geospatialem commented 1 month ago

cc https://github.com/Esri/calcite-design-system/pull/10292

geospatialem commented 1 month ago

Fix was shipped with https://github.com/Esri/calcite-design-system/pull/10309 and a chore was added to ensure the naming conventions are met. šŸš€

github-actions[bot] commented 1 month ago

Installed and assigned for verification.

DitwanP commented 1 month ago

@geospatialem I see the icon but the error in the console is still present, is this issue good to close out?

geospatialem commented 1 month ago

I see the icon but the error in the console is still present, is this issue good to close out?

Summarizing our chat discussion here for any folks following along - the fix has shipped, but verification will take place once Calcite's 2.12.2 and UI Icons 3.32.0 are available later this month. šŸš€

DitwanP commented 1 month ago

šŸ” Verified on Ui Icons 3.32.0 image