Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
295 stars 76 forks source link

[Dialog] All keydown events trapped when escape-disabled is present #10410

Closed ellenupp closed 2 months ago

ellenupp commented 2 months ago

Check existing issues

Actual Behavior

When escape-disabled is present on a dialog, all keydown events are prevented so you can't for example tab between focusable elements or type in an input.

Expected Behavior

escape-disabled only impacts keydown on escape key

Reproduction Sample

https://codepen.io/ellupp/pen/poMJEOp?editors=1000

Reproduction Steps

  1. Try typing in the input in the dialog, nothing happens

Reproduction Version

2.12.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

needed for us to start using dialog in place of modal

Calcite package

Esri team

ArcGIS Dashboards

geospatialem commented 2 months ago

@ellenupp this should be mitigated in the upcoming 2.13.0 release via https://github.com/Esri/calcite-design-system/pull/10336.

Here's an example of the verification locally if of interest:

verified

Going to mark the above as a duplicate and close it out. 👍🏻

ellenupp commented 2 months ago

Ah thanks, only checked for duplicates in open issues!

geospatialem commented 2 months ago

Ah thanks, only checked for duplicates in open issues!

Absolutely no worries, appreciate you filing so we can investigate either way! 🤜🏻🤛🏻