Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
285 stars 76 forks source link

calcite-action ARIA attributes #10411

Open vivzhang opened 4 days ago

vivzhang commented 4 days ago

Check existing issues

Summary

Remove the aria-disabled and aria-busy attributes on calcite-action. Please ignore the request for aria-label, the Hub team will address that by passing in a unique value for the label property for their use case.

Original AMP issues: 11242 11244

Actual Behavior

aria-disabled and an aria-busy attributes rendered on the button inside calcite-action

Expected Behavior

No aria-disabled and aria-busy rendered on the button inside calcite-action

Reproduction Sample

https://codepen.io/vivzhang/pen/rNXVWBo

Reproduction Steps

  1. Open the devtool console
  2. Inspect the calcite-action component
  3. You should see the aria-disabled and an aria-busy attributes rendered on the button element

Reproduction Version

2.12.1

Working W3C Example/Tutorial

No response

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

Esri team

Arcgis Hub

jcfranco commented 1 day ago

Some notes: