Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
287 stars 76 forks source link

[ESLint] remove ban-props-on-host ESLint rules #10422

Open maxpatiiuk opened 2 weeks ago

maxpatiiuk commented 2 weeks ago

Priority impact

p - low

Summary

Blocked by https://github.com/Esri/calcite-design-system/issues/10310

Calcite developed an ban-props-on-host ESLint rule. Such rule is not applicable in Lumina because <Host> does not exist in Lit.

Instead, you can set props or attributes imperatively inside of connectedCallback or render. It seems like Stencil's <Host> didn't check if attributes were already set by the user and would overwrite them. Imperatively, you can use ??= instead of = when assigning props to avoid overwriting existing value. The codemod takes care of migrating all <Host> usages.

Desired Outcome

After migrating to Lumina, remove the ban-props-on-host ESLint rule.

Resources

No response

maxpatiiuk commented 2 weeks ago

Blocked by https://github.com/Esri/calcite-design-system/issues/10310