Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
293 stars 76 forks source link

modal: buttons exceed modal container when they have long text #10486

Open dFranz2 opened 1 month ago

dFranz2 commented 1 month ago

Check existing issues

Actual Behavior

Buttons with long strings will overflow beyond the modal container. This was discovered when testing pseudo-translations.

Expected Behavior

I would expect buttons to have a max width that's proportional to the modal scale, if the width is not set. The strings should be truncated if the text exceeds the button width.

Reproduction Sample

https://codepen.io/dmap/pen/rNXeJqr

Reproduction Steps

  1. Create a modal
  2. Add buttons (primary, secondary, and back) with long text

Reproduction Version

2.13.0

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

Minor. We can add a temporary fix by setting a max-width on the buttons used in modals

Calcite package

Esri team

ArcGIS Web Analysis

siq10677 commented 1 month ago

There is a similar case with calciate-popover.

image