Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
286 stars 76 forks source link

[Dialog] Alert slot blocks footer actions #10514

Open mpayson opened 1 week ago

mpayson commented 1 week ago

Check existing issues

Actual Behavior

The alert slot blocks footer actions. This looks a little weird, and can make it hard to click a "Cancel" button slotted in the footer

Expected Behavior

Alert displays above the footer

Reproduction Sample

https://codepen.io/mpayson/pen/rNXWWaO

Reproduction Steps

  1. Open the codepen

Reproduction Version

2.13

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

May limit our ability to use the alerts slot

Calcite package

Esri team

ArcGIS Data Pipelines

mpayson commented 1 week ago

Looks like this can be worked around by setting a transform style on the alert. This can probably be changed to p3

macandcheese commented 1 week ago

I know we've talked about "pinning" the slot to the Content area - which could help most default use cases prevent overlap with Footer content, probably the most common layout. However, I think there is always a risk of unwanted overlap with < unknown content >.

There seems to have been a change.... --calcite-alert-edge-distance was made into an internal property. Before this change, this was a public property where users could adjust as needed: https://codepen.io/mac_and_cheese/pen/zYgomqq?editors=1000

I'd think we restore it to support these use cases (within Dialog, Panel, or anywhere elsewhere an Alert may overlap content)