Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
289 stars 76 forks source link

[text-area] Max length can't be safely removed #10619

Open mpayson opened 2 weeks ago

mpayson commented 2 weeks ago

Check existing issues

Actual Behavior

When removing the text-area max-length attribute, the component gets into a bad state where the text gets removed but the user will see a red border if they type in any characters.

This happens either when using maxLength={undefined} in Stencil or textAreaElement.removeAttribute("max-length"). It does not happen when explicitly setting textAreaElement.maxLength = undefined, however this causes typescript to complain.

Expected Behavior

When max-length is removed, the component acts as if max-length was never set.

Reproduction Sample

https://codepen.io/mpayson/pen/mdNpdaR

Reproduction Steps

  1. Open the sample
  2. Click the button
  3. Start typing in text, see a red border appears

Reproduction Version

2.13.0

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

Esri team

ArcGIS Data Pipelines

jcfranco commented 2 weeks ago

This will likely get resolved by #10310.