Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
290 stars 76 forks source link

`input-time-picker` + `focus-trap-disabled` should close when keyboard focus moves away #10639

Open jcfranco opened 2 weeks ago

jcfranco commented 2 weeks ago

Check existing issues

Actual Behavior

When tabbing outside of an open, focus-trap-disabled, input-time-picker's input or time-picker parts, the component stays open.

Expected Behavior

When focus moves outside of the component, it should close. This will be consistent with other components (e.g., input-date-picker, combobox)

Reproduction Sample

https://codepen.io/jcfranco/pen/dyxdrax?editors=100

Reproduction Steps

  1. Tab to input-time-picker
  2. Press down
  3. Tab until focus moves out
  4. Notice component stays open

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

Esri team

Calcite (dev)

geospatialem commented 1 day ago

Related to the consistency aimed with https://github.com/Esri/calcite-design-system/issues/10522