Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
290 stars 76 forks source link

Add a reveal action to `calcite-input` with type "password" #10730

Open ethanbdev opened 5 hours ago

ethanbdev commented 5 hours ago

Check existing issues

Description

We have a requirement for a UI that reveals hidden text in a calcite input. It would be really handy if the design system handled this, giving us an opt-in reveal action for a password input type.

Acceptance Criteria

When input is type password, we can opt-in to a reveal action that shows the actual text instead of the hidden text. We would want this to work in all major browsers.

Relevant Info

Some browsers already implement this with the native password input (like edge): 2024-11-14_12-29-50 (1)

There is also an issue for this in the html spec: https://github.com/whatwg/html/issues/7293

Edge also adds the reveal to the calcite input, but it would be great to align the design across browsers for our users.

Which Component

calcite-input

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

Esri team

ArcGIS Web Analysis

macandcheese commented 4 hours ago

I think this is a great enhancement and one that could justify a standalone calcite-input-password component to align with our newer components like calcite-input-text, calcite-input-number, etc.