search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
293 stars 76 forks source link

split accordion-item header and content padding #10762

Open alisonailea opened 5 days ago

alisonailea commented 5 days ago

Check existing issues

Description

https://github.com/Esri/calcite-design-system/pull/10721#pullrequestreview-2437271640

The current design pattern for accordion item is to have content and heading padding size in unison.

Acceptance Criteria

The proposed design pattern is accordion item heading and content padding size separately.

Relevant Info

No response

Which Component

accordion-item

Example Use Case

As a developer I want the padding of the accordion-item heading to be 10px and the content padding to be 0px.

Priority impact

impact - p3 - not time sensitive

Calcite package

Esri team

Calcite (design)

geospatialem commented 2 days ago

@alisonailea Can you update the labels for verification? I've added in the labels and express triaged the above to November/current milestone.

github-actions[bot] commented 2 days ago

Installed and assigned for verification.

DitwanP commented 1 day ago

@alisonailea I think the padding token is still applying to both heading and content, but maybe I'm missing something.

Accordion demo page with calcite-accordion-item { --calcite-accordion-item-content-space: 40px; }: https://github.com/user-attachments/assets/9aaea4fd-2668-42c1-8ac1-97826d5355bb