Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
277 stars 76 forks source link

Epic: Consistent font/size, spacing scale, color, etc for components #1500

Closed jrowlingson closed 2 years ago

jrowlingson commented 3 years ago

Description

Enable consistency throughout the component library of font/size, spacing scale, color, shadow, focus states, etc.

Now that @asangma 's tailwind configuration refactor has landed (https://github.com/Esri/calcite-components/pull/1415), we should be in a good spot to begin the larger component refactor to use said configuration. I'd suggest grabbing a range below (e.g. a-b) if you are interested in helping out.

Acceptance Criteria

Relevant Info

Which Component

Final steps

Bonus

jrowlingson commented 3 years ago

Grabbing calcite-a* through calcite-b*

asangma commented 3 years ago

I'll take calcite-c* through calcite-d* once #1520 lands.

jrowlingson commented 3 years ago

Grabbing calcite-f* through calcite-h*

paulcpederson commented 3 years ago

gonna rip through calcite-modal and also calcite-loader

paulcpederson commented 3 years ago

WE really need to do something about the border situation. Very annoying to not be able to set borders via the apply rules.

paulcpederson commented 3 years ago

Maybe also a transition-1 or some other configured transition helper for applying out main transition

paulcpederson commented 3 years ago

Going to try and tackle stepper today!

caripizza commented 3 years ago

Grabbing calcite-tab, calcite-tabs, calcite-tab-nav, and calcite-tab-title

julio8a commented 3 years ago

Taking calcite-f to calcite-h

caripizza commented 3 years ago

@jrowlingson I can open a pr to revert that 3px border width addition in the tailwind config. I only added it because I thought calcite-tabs needed the 3px border to stay, but since calcite-notice now has a border width of 2px, I went with that for calcite-tab-nav and calcite-tab-title as well.

jrowlingson commented 3 years ago

@caripizza that would be great!

asangma commented 3 years ago

Hey y'all. I'm backed up with a bunch of fixes and will have to come back to this refactor later. Please feel free to take on C and D.

caripizza commented 3 years ago

Grabbing calcite-button today

julio8a commented 3 years ago

2041 should be part of the refactor work ^

jcfranco commented 3 years ago

Will this also cover renaming color props to status or something more indicative of its intent? I landed onto this issue from https://github.com/Esri/calcite-components/issues/1220, but I don't see mention of this here. Let me know if we need to break this off into a separate issue. cc @asangma

caripizza commented 3 years ago

@jcfranco not included in this one, no. I'll review that work with @bstifle and @macandcheese, then we'll create a new issue to address.

jcfranco commented 3 years ago

@caripizza Awesome, thanks!

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 years ago

This issue has been automatically closed due to inactivity.

github-actions[bot] commented 2 years ago

This issue has been automatically closed due to inactivity.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 years ago

This issue has been automatically closed due to inactivity.

jcfranco commented 2 years ago

I believe this has been addressed now. @macandcheese @caripizza can you confirm? cc @benelan

caripizza commented 2 years ago

@jcfranco yep I'd prefer to close this one at this point, if anything we can just refer to this closed issue if we need to track future work. Otherwise we can plan to close this one after we review the spacing audit from #2972 with @asangma?

jcfranco commented 2 years ago

Thanks for the info, @caripizza.

I'll leave it up to @macandcheese and @HeathMeyette to decide how to proceed with this issue and the remaining tasks from the description that have no associated PR/issues.

macandcheese commented 2 years ago

I agree that https://github.com/Esri/calcite-components/issues/2972 encompasses the work described in this issue.