Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
289 stars 76 forks source link

Enhancement: Selection visuals for Tree #2082

Closed bstifle closed 3 years ago

bstifle commented 3 years ago

Remove left-hand bar single selection active state style: image

bstifle commented 3 years ago

Tree Specs

macandcheese commented 3 years ago

Comps look good, great alignment

🔲🔲 🔲🔲

It seems like the "checkbox" design functions differently than "check icon" - are parent-level items not selectable in that mode?

bstifle commented 3 years ago

to my understanding no, which is kind of a neat differentiator imo

macandcheese commented 3 years ago

Ok, it might be worth looking how these three layouts map to all 5 of the selection-modes, and how it interacts with the show-input prop (if they need to both still remain)?

If we can make that decision for them based on mode, we'll have less of a tree-mode-potpourri across our apps. Just props for theme, lines, scale is nice.

evanmosby commented 3 years ago

Looking forward to these options with ArcGIS Monitor! Especially the center option (checks w/o box) for facet filter multi-select!

caripizza commented 3 years ago

Tree scales were installed in pr #2803.

Next I'll fine-tune the selection visuals with Bryan in Figma. We'll need to support all 5 of tree's selection-modes, which were implemented according to the specs here:

(Descriptions and screenshot examples for our current tree behavior in each selection-mode can be found in the markdown table here.)

caripizza commented 3 years ago

@bstifle I'm blocked on this one until I know what tree should look like in all 5 selection modes. Can you please clarify?

bstifle commented 3 years ago

@caripizza

image with lines: image

https://www.figma.com/file/E3SB0i5wPy7AagB7KcjF05/?node-id=1183%3A21400

benelan commented 3 years ago

Verified on storybook after beta.64 release. Awesome stuff! https://esri.github.io/calcite-components/?path=/story/components-tree--simple