Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
286 stars 76 forks source link

Bug: Drag-n-Drop for value list and block not working on touch #2489

Open thomasknabl opened 3 years ago

thomasknabl commented 3 years ago

Actual Behavior

Drag-n-Drop for value list and block not working on touch in the following two cases. To be precise on iPad there is no dragging at all on win chrome touch you can drag a list entry but you can't drop it.

https://esri.github.io/calcite-components/?path=/story/components-value-list--basic&knob-class=calcite-theme-light&knob-dir=ltr&knob-disabled=&knob-dragEnabled=true&knob-filterEnabled=&knob-loading=&knob-multiple=&knob-selection-follows-focus=

https://codepen.io/dhrumil83/pen/PoNNNMd

Expected Behavior

Items can be dragged and dropped on touch devices.

Reproduction Steps or Sample

  1. Open the mentioned examples above
  2. Try to drag and drop the items

Relevant Info

Chrome/Win, Safari/iPad

Version: @esri/calcite-components@<version>

cc: @jcfranco , @asangma

driskull commented 2 years ago

I think theres a few issues here, mostly that the two sortable lists aren't playing well together and that is not easy or really possible to separate them at this time.

The demo should be updated so that both the calcite-sortable-list as well as the calcite-value-list both have unique group properties that will allow them to work separately.

That can be seen here: https://codepen.io/driskull/pen/bGvLKdX?editors=1000

However, after that there is still an issue with dragging because the handle selectors cant be distinguished from each other. There's no way to set the handle selector for the drag enabled block. You can set the handle selector for the sortable list but its not apparent how to scope it only to the blocks. @jcfranco we need to do some work here I think or just not say nested sortable lists are not currently supported.

geospatialem commented 1 year ago

This issue will be prioritized after the 1.0 release next month.

jcfranco commented 1 year ago

I believe this has been addressed by https://github.com/Esri/calcite-design-system/pull/6983. @driskull Can you confirm?