search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
286 stars 76 forks source link

Enhancement: Add input masking to `input-time-picker` #2709

Open AdelheidF opened 3 years ago

AdelheidF commented 3 years ago

Description

~Create a new calcite-input-time component to be used by calcite-input-time-picker to solve issues https://github.com/Esri/calcite-components/issues/2331 and https://github.com/Esri/calcite-components/issues/2329~

Repurposing this issue

Let's add input masking to the input-time-picker component to support time selections without a picker.

From @eriklharper

~I discussed this with @jcfranco and we came up with the idea to create a new calcite-input-time component that will replace the current input box inside calcite-input-time-picker which will be modeled after the native browser implementations like this one from Chrome:~

image

The behavior will essentially change from being a free-form text field, to established input fields that act as a mask for entering time values.

Acceptance Criteria

Relevant Info

Which Component

input-time-picker

Example Use Case

jcfranco commented 2 years ago

Linking to discussion: https://github.com/Esri/calcite-components/discussions/4360

BlakeStearman commented 2 years ago

The home app team is also interested in this enhancement. We're currently using input-time-picker in our UI for scheduling tasks where a start or end time is needed when rebuilding hosted scene layers on a schedule, and had also run into the behaviors that https://github.com/Esri/calcite-components/issues/2331 and https://github.com/Esri/calcite-components/issues/2329 cover. Notebook task scheduling is still using a very old Dojo time input, so we are looking to move to input-time-picker presently as well.

eriklharper commented 2 years ago

The home app team is also interested in this enhancement. We're currently using input-time-picker in our UI for scheduling tasks where a start or end time is needed when rebuilding hosted scene layers on a schedule, and had also run into the behaviors that #2331 and #2329 cover. Notebook task scheduling is still using a very old Dojo time input, so we are looking to move to input-time-picker presently as well.

Great to hear, I am currently working on this component!

geospatialem commented 1 year ago

This new component will continue work in February and is anticipated to land in the February 2023 release.

geospatialem commented 1 year ago

Reallocating to the April milestone to tackle.

geospatialem commented 1 year ago

Localization research has been performed. Implementation has been moved to the upcoming May release.

github-actions[bot] commented 1 year ago

cc @ashetland, @SkyeSeitz, @brittneytewks

geospatialem commented 1 year ago

Will be adding millisecond support to input-time-picker, this new component will leverage when it lands. As a result this issue is blocked by millisecond effort in #6591.

Targeting the effort for later this year in December.

eriklharper commented 1 year ago

Related issue that can be addressed by a masked input: https://github.com/Esri/calcite-design-system/issues/6898

geospatialem commented 1 month ago

@AdelheidF We've updated the above scope to accommodate the current input-time-picker component through masking as an enhancement.

Based on the above workflow, we may seek consistency with input-date-picker once a pattern is established. cc @eriklharper @jcfranco