Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
279 stars 76 forks source link

Enhancement: add month-year and year appearance to calcite date picker #3455

Open fendiaoxiaoshuazi opened 2 years ago

fendiaoxiaoshuazi commented 2 years ago

Description

Support month-year and year only appearance in the calcite date picker.

Here are the screenshots of the month-year and year only appearance in bootstrap date picker image image

Acceptance Criteria

Relevant Info

Blocked issues: #9167, #8624

Which Component

calcite-date-picker

Example Use Case

fendiaoxiaoshuazi commented 2 years ago

Hi calcite team, I am a PE of the Survey123 team, and we are currently working on replacing our date and time picker with the calcite date and time picker for better A11y and I18N support. The month/year and year only appearance is critical for us, so we cannot fulfill the replacement at this point.

Do you have a timeframe time for this enhancement to be implemented?

fendiaoxiaoshuazi commented 1 year ago

Hi Calcite team, we have partially replaced our pervious Wijimo date/time picker with the Calcite date/time picker. Since Calcite does not support month year and year only appearances, we have to keep the Wijimo date picker to support these appearances.

Therefore, we need to load 2 different libs for the date/time question, and there are many month year and year only appearances I18N issues are impeded by the replacement work.

We are waiting for Calcite to support month year and year only appearances to proceed with the replacement work. Do you have a timeframe time for this enhancement to be implemented?

fendiaoxiaoshuazi commented 1 year ago

Hi Calcite team, we need to upgrade node.js to the latest version as required by the Security team, and we probably have to drop the Wijimo lib which we currently use for month-year and year-only appearances.

Therefore, Calcite's month-year and year-only appearances support become the pre-requisite of our node upgrade. We plan to upgrade node.js and drop Wijimo in our UC Release. If possible could you please prioritize this issue, and address this issue before May?

benelan commented 1 year ago

Hi @fendiaoxiaoshuazi, sorry for the delay! I'll make sure to bring it up again during our next triage. It is definitely a valid use case and something we would like to implement. However it is unlikely to be done by May, since it would require design and i18n feedback before development can start.

Which Node version are you currently on? If you're on an Active or Maintenance LTS version, updating to the latest minor/patch version should be sufficient security-wise. That should give us more time until your current date components need to be replaced.

https://nodejs.org/en/blog/vulnerability/february-2023-security-releases/

We are also revamping some of our processes so we can better communicate our plans and progress. Our original triage was scaled down during the lead up to v1, but we are starting to work through the back-fill. Thanks for the patience everyone!

yixi8524 commented 1 year ago

@benelan Thanks for your prompt reply. We are still in Node.js 14 & NPM6 env. We must plan the next release to upgrade our Env and libs. Not only Node.js also include NPM, Webpack, Angular Framework, etc. So this is a good time to refactor our lib. If we can retire the Wijimo ASAP, it can let us easy to control the i18n and the A11Y support. Give the same and better UX experience to our users.

SkyeSeitz commented 1 year ago

Howdy folks! Can I get some eyes on this proposed design ? Looking for feedback before moving any further. Thanks! @macandcheese @jcfranco

image
SkyeSeitz commented 1 year ago

Updated and expanded the scope of the proposed design based on design and engineering feedback from the team. Updated specs can be found here.

SkyeSeitz commented 8 months ago

Updated specs in Figma after some hot potato: https://www.figma.com/file/eP9IJjZV95HVKRCbNmW6eX/Date-Picker-Redesign-%5B3455%5D?type=design&node-id=898%3A41827&mode=design&t=FWbpCQwwI4Ey9k7C-1

geospatialem commented 7 months ago

Could the redesign of the component also account for https://github.com/Esri/calcite-design-system/issues/6410, where when the component is in scale of "l". cc @anveshmekala

anveshmekala commented 7 months ago

Could the redesign of the component also account for #6410, where when the component is in scale of "l". cc @anveshmekala

yeah, the redesign will resolve that issue, user's can select years rather than typing them.

anveshmekala commented 1 month ago

Attaching wiki notes for reference.

cc @jcfranco @geospatialem @SkyeSeitz