search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
279 stars 76 forks source link

Change accordion-item's header to use a semantic <button> instead #4123

Open jcfranco opened 2 years ago

jcfranco commented 2 years ago

Description

The current header element uses a <div> and it would be useful to replace it with a <button> (similar to calcite-block).

Proposed Advantages

Promotes semantic HTML.

Which Component

calcite-accordion-item

Relevant Info

Stems from https://github.com/Esri/calcite-components/pull/4086#discussion_r808325809

macandcheese commented 2 years ago

Is this needed after changes made here: https://github.com/Esri/calcite-components/pull/4822

geospatialem commented 9 months ago

Spike to determine if the semantic button is needed, re: https://github.com/Esri/calcite-design-system/issues/4123#issuecomment-1174034347

DitwanP commented 3 months ago

We do still want to tackle this one because "it can still eliminate some additional code by leveraging semantic elements." -Franco

github-actions[bot] commented 3 months ago

cc @geospatialem, @brittneytewks