search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
292 stars 75 forks source link

openCloseComponent: apply the interface to additional components to have consistent eventing for opening/closing #5056

Closed Elijbet closed 12 months ago

Elijbet commented 2 years ago

Description

Implement openCloseComponent Interface by using the new onToggleOpenCloseComponent pattern. This new pattern is intended to simplify the overall eventing logic.

Acceptance Criteria

Components implement the interface to consistently handle emitting open, beforeOpen, close, beforeClose events.

Relevant Info

Related to PR #4975 and original Issue: #4689

Which Component

Example Use Case

No response

jcfranco commented 1 year ago

Let's use this issue to drive implementing the pattern/util. Can you assimilate https://github.com/Esri/calcite-design-system/issues/6017 here and close it afterwards?

Elijbet commented 1 year ago

Some components (tooltip, popover, input-date-picker) have also been covered in the following issue: #7358

github-actions[bot] commented 1 year ago

Installed and assigned for verification.

geospatialem commented 12 months ago

Verified on the main branch for the following components: