search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
289 stars 76 forks source link

Button - ensure CSS vars are using underlying calcite-colors and are not re-aliased #546

Closed macandcheese closed 4 years ago

macandcheese commented 4 years ago

calcite-button was built before calcite-colors were available as CSS vars and as such has a ton of re-aliased values that cause headaches for theming using our defined set of vars in calcite-colors.

Update the component to use only defined CSS vars, and generally clean up the CSS for how we generate our veritable bevy of appearance and color combinations.

paulcpederson commented 4 years ago

@macandcheese I've started this on the theme branch: https://github.com/Esri/calcite-components/commit/a9c70b8f88079207e2aca0306fd9dc10e7088992

paulcpederson commented 4 years ago

Not sure how we want to handle dark button color though, we don't have all those values as part of the theme...