search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
270 stars 75 forks source link

Remove the need to set calcite-input's internal input value in calcite-color-picker #6100

Open benelan opened 1 year ago

benelan commented 1 year ago

Description

Color Picker is currently setting the value for both calcite-input and its internal input in handleChannelInput. We should figure out why it needs to do that and refactor it if possible.

Proposed Advantages

Updating component's internals is an anti pattern. It is effectively going into the shadowRoot. Setting the value of the calcite-input should update its internals. We may need a lifecycle methods refactor for calcite-input.

Which Component

Relevant Info

Here is a comment with some context https://github.com/Esri/calcite-components/pull/5908#discussion_r1040562755

This PR (will) remove the deprecated nativeEvent event payload in favor of an intenal Input method to make sure Color Picker doesn't break. This is a temporary change until we can refactor, since we need to move all of the deprecations now

6099

geospatialem commented 5 months ago

Research spike needed to determine the scope and estimate needed to achieve.