search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
290 stars 75 forks source link

[Stepper] - Remove `goTo...` methods from Stepper #6134

Closed macandcheese closed 7 months ago

macandcheese commented 1 year ago

Description

This pattern of using methods (goToStep(),endStep(),startStep(),nextStep(),prevStep()) to navigate steps is an outdated pattern - we should refactor the component to no longer use / accept these methods (internally as well as externally). The public story should be to assign / adjust the selected property as needed on the desired stepper-item.

Proposed Advantages

Bring the stepper and stepper-item component in line with more recent patterns.

Which Component

Stepper / Stepper Item

Relevant Info

No response

jcfranco commented 1 year ago

I'm not sure I agree with this request. What you're proposing means that the user would need to store references to all items, or query the DOM for them, and manage selection as the user interacts with the app. Is this correct?

macandcheese commented 1 year ago

This issue was opened as the result of a Teams discussion or issue follow up (can’t remember), where it was noted this was kind of a one off pattern.

If it’s fine to keep them around we can disregard this and maybe add a guideline around it.

macandcheese commented 7 months ago

Closing based on discussion - original issue was brought up in Teams but we are choosing not to pursue at this time.