search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
285 stars 76 forks source link

[pagination]: Uses deprecated props #6365

Closed jasdelreyes closed 1 year ago

jasdelreyes commented 1 year ago

Actual Behavior

Calcite pagination is incorrectly showing the numbers provided in the props.

Below you can see screenshots of the pagination component showing "0" instead of, for example, "1 2 3". The header on top is showing the inputs I've added to the calcite-pagination props.

First render

pagination1

When "0" is clicked

pagination2

Expected Behavior

I expect the pagination component to show the correct sections of pages -- which are also clickable to then change the local variables to show different pages in the UI.

Reproduction Sample

https://codepen.io/jasdelreyes/pen/abjKqPL?editors=100

Reproduction Steps

  1. Use calcite-pagination as outlined in https://developers.arcgis.com/calcite-design-system/components/pagination/ with the camelCase props.
  2. Open devTools
  3. See that the props include deprecated props.

Source code

pagination-source

Reproduction Version

1.0.3

Relevant Info

Firefox 109.0, Chrome 109.0.5414.119

Regression?

Yes

Impact

This is used in the new append experience aimed for R01. This is the prohibiting the ideal behavior of a workflow.

Esri team

ArcGIS Online

brittneytewks commented 1 year ago

@jasdelreyes Is this still an issue? The codepen you show is working as expected, or can you follow up with another example that shows the issue?

jasdelreyes commented 1 year ago

@brittneytewks This is resolved!

geospatialem commented 1 year ago

Great news, and thanks for the quick reply, @jasdelreyes! We'll close out the issue.