Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
290 stars 75 forks source link

calcite-input-time-picker - Add support for fractional seconds #6591

Closed richiecarmichael closed 1 year ago

richiecarmichael commented 1 year ago

Description

The calcite-input-time-picker needs to be extended to support milliseconds. Specifically the component needs an option to include milliseconds in the display and also an editing experience.

image

Perhaps:

<calcite-input-time-picker fractionalSecondDigits=3 value="13:07:04.102" />

Acceptance Criteria

Relevant Info

No response

Which Component

<calcite-input-time-picker />

Example Use Case

No response

Esri team

ArcGIS Maps SDK for JavaScript

Reference

  1. JSAPI - Enhancement - Editor- Support New Date Fields (see #50595)
  2. JSAPI - Enhancement - FeatureTable - Support New Date Fields (see #50596)
geospatialem commented 1 year ago

This request is a requirement of the Maps SDK for JavaScript to support new date fields throughout the ArcGIS ecosystem - should be paired with the creation of a new component from #6590.

ashetland commented 1 year ago

Tagging this for necessary updates to Figma component. cc @SkyeSeitz

richiecarmichael commented 1 year ago

Just updated the proposed design:

From:

<calcite-input-time-picker showMilliseconds=true value="13:07:04.102" />

To:

<calcite-input-time-picker fractionalSecondDigits=3 value="13:07:04.102" />

...to align with Intl's fractionalSecondDigits property. This provides greater control (i.e. tenth, hundredth or thousandth of a second) depending on the precision of the data.

fractionalSecondDigits (on MDN) states that valid values are 0, 1, 2 and 3. However that this differs from ES2021 which only allows undefined, 1, 2 and 3. This discrepancy is logged and backlogged here. I would suggest using values 0, 1, 2 and 3.

SkyeSeitz commented 1 year ago

Design specs complete and available at the links below. Time Picker: https://www.figma.com/file/fBkmuAy3R4BfjAWlRi2KjS/Calcite-Web-UI-Kit?node-id=10501%3A265212&t=6m3XXmjynq4AoQio-1 Input Time Picker: https://www.figma.com/file/fBkmuAy3R4BfjAWlRi2KjS/Calcite-Web-UI-Kit?node-id=12360%3A246650&t=6m3XXmjynq4AoQio-1

geospatialem commented 1 year ago

Reallocating to the May milestone, where it is expected to land soon for additional texting in next.

ubatsukh commented 1 year ago

@jcfranco we will not using this component at 4.27 as we decided to only support read-only versions of the new date/time fields at 4.27. However, we will pick up this component as soon as the 4.27 is released.

You can find the general updates on adding support for new date/time fields from this planning doc issue: https://devtopia.esri.com/WebGIS/arcgis-js-api-planning-docs/issues/287#issue-1369706

geospatialem commented 1 year ago

Reallocated to the upcoming July milestone per the discussion above.

geospatialem commented 1 year ago

Reallocated to the August milestone with the UC approaching and addressing critical bugs in next week's June patch release.

jcfranco commented 1 year ago

Passing the torch to @eriklharper for this one. 🔥🔥🔥

github-actions[bot] commented 1 year ago

Installed and assigned for verification.

geospatialem commented 1 year ago

Verified in 1.7.0-next.17 with the following:

<calcite-input-time-picker step="0.1" value="10:37:09.5"></calcite-input-time-picker>