search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
289 stars 76 forks source link

[Navigation Logo] Refactor component to conditionally render anchor or div #7078

Open macandcheese opened 1 year ago

macandcheese commented 1 year ago

Description

Follow up from https://github.com/Esri/calcite-components/issues/6606

Acceptance Criteria

The Navigation Logo component should conditionally render an anchor or div element depending on the presence of 'href' - similar to Button.

Relevant Info

No response

Which Component

Navigation Logo

Example Use Case

This will enable better keyboard support and focus handling. Currently you cannot easily set up the component to be focusable and not have a navigation href.

Priority impact

p3 - want for upcoming milestone

Esri team

Calcite (design)

geospatialem commented 6 months ago

Should be tackled in the same milestone as #9139.