Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
289 stars 76 forks source link

[List], [List Item], [List Item Group]: add scales, update padding and pacing, update font sizes #7100

Open ashetland opened 1 year ago

ashetland commented 1 year ago

Description

Add scales and related updates to List, List Item, and List Item Group. See this Figma file for full specs. Note that file also contains other related updates to List.

Acceptance Criteria

Relevant Info

These are updated designs since this issue was originally created. They prioritize reducing unnecessary whitespace around elements to conserve horizontal real estate, 24px AA minimum hit targets, and improving visual hierarchy when nesting.

Pair with #9173, #9174, and #9175

Full specs available in Figma file, before/after reference below: Slice 1

Which Component

List List Item List Item Group

Example Use Case

No response

Priority impact

p3 - want for upcoming milestone

Esri team

Calcite (design)

driskull commented 11 months ago

We may wan to reconsider how we indent child items as well. Currently, we only indent within the item but not the whole item.

image

The problem with this is that the selection is still far to the side and when dragging a child there isnt a good way to distinguish where its going because they are all indented the same. No matter how deep the child is, the element spans the whole width.

I think we did this originally so that the hover/active/focus spans the whole width of the list but I think we should reconsider.

image
driskull commented 10 months ago

@ashetland can the "indent entire item" be included in this as well? Do we have approval/consensus to do that?

ashetland commented 10 months ago

@ashetland can the "indent entire item" be included in this as well? Do we have approval/consensus to do that?

Yep, happy to look at that for this. I did start exploring some options, but haven't run any of the visuals by @SkyeSeitz or @macandcheese yet.

ashetland commented 10 months ago

Thanks for your patience on this one, @driskull! We'd like to hold off on making the updates outlined above for now. After more discussion, we've decided it would better to take a deeper look into nesting and grouping List Items. We're going to pull this one back into the design pipeline and I will update the issue description accordingly. cc @SkyeSeitz @macandcheese @geospatialem

driskull commented 10 months ago

Sounds good. Just want to again push for nesting the whole item as it provides better UX and visual feedback for dragging an item. Without nesting the whole item, its difficult to tell where the item is actually being placed when nested items occur.

nested-drag-ux

zaramatheson commented 10 months ago

image Another example from Map Viewer using a heavily nested KML layer of the difference after updating to the calcite list (right)

driskull commented 10 months ago

@ashetland @jcfranco any way we can bump the priority on this one?

ashetland commented 10 months ago

Ouch. Yes.

sagewall commented 10 months ago

cc @sagewall

jgrayson-apl commented 9 months ago

+1 for having a more pronounced visual difference between the calcite-list-item label and description please. Here's an example of what we struggle with where we need the label to be larger in size:

f587b254-a940-4a05-a23e-a4c085df8238

This next one is an attempt to distinguish the two by using the only means currently possible, the colors:

0d41928a-4072-4259-bcd9-aad47aecae91

ashetland commented 9 months ago

As part of the refinement of the designs for this, we intend on incorporating the font sizes outlined in issue #7623. The above example would look like this post-implementation: Frame 259

ashetland commented 8 months ago

Updated issue title and description to reflect new designs.

github-actions[bot] commented 8 months ago

cc @geospatialem, @brittneytewks

ashetland commented 6 months ago

@driskull I've updated the title and description of this issue based on our discussion and the new designs. I also added the breaking changes and visual changes labels.

driskull commented 6 months ago

@geospatialem @ashetland I think this should be moved milestone since it will have breaking changes. right?

ashetland commented 6 months ago

Makes sense to me

geospatialem commented 6 months ago

Thanks @driskull and @ashetland, and great catch!

We'll be planning the breaking change release timeline in the next few weeks. Stay tuned for when we can add this to an upcoming milestone.

ashetland commented 6 months ago

Thanks @geospatialem! This should also be paired with #9173 and #9174.

driskull commented 4 months ago

@ashetland @geospatialem do we have a milestone for this issue?

geospatialem commented 4 months ago

@ashetland @geospatialem do we have a milestone for this issue?

@driskull Added the above, https://github.com/Esri/calcite-design-system/issues/9173 and https://github.com/Esri/calcite-design-system/issues/9174 to November's milestone for the breaking changes.