Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
269 stars 75 forks source link

Provide unique link text to assistive technology #7210

Closed shellchulx closed 1 week ago

shellchulx commented 1 year ago

Description

Currently, the semantics are not mapped to the accessibility API for calcite-link with the role="presentation", which the Calcite team explains as why the aria-label isn't read back to all AT. An enhancement request to add support for a label attribute for calcite-link could help fix this. Screenshot 2023-06-21 at 4 27 05 PM

cc @catherinehynes

Acceptance Criteria

NVDA will read the aria-label

Relevant Info

No response

Which Component

calcite-link

Example Use Case

No response

Priority impact

p4 - not time sensitive

Esri team

ArcGIS Enterprise

geospatialem commented 1 year ago

@shellchulx Could you provide a use case for the benefit of a label over the current slotted link text for us to consider and prioritize the enhancement?

catherinehynes commented 1 year ago

@geospatialem The ArcGIS Enterprise accessibility evaluation at 10.9.1 included an audit of the portal home app Organization > Licenses page, which has a Manage link for many different types of add-on licenses:

image

This is where we were hoping to add a label for each link so we could have a more descriptive name for AT.

geospatialem commented 1 year ago

This is where we were hoping to add a label for each link so we could have a more descriptive name for AT.

Thanks for the quick response, @catherinehynes! Out of curiosity could the button component work in this use case? Wondering if perhaps it could provide a similar use case, as it contains href and label attributes.

For instance: https://codepen.io/geospatialem/pen/dyQOyEZ

geospatialem commented 9 months ago

@catherinehynes @shellchulx Would the above recommendation with button fit the use case? If changing the component altogether isn't feasible, could a .sr-only, or similar, span element be added to provide unique context?

catherinehynes commented 9 months ago

@geospatialem I believe the button would work - @shellchulx could you weigh in?

geospatialem commented 1 month ago

@catherinehynes @shellchulx Circling back to the above, was button able to achieve the need?

geospatialem commented 1 week ago

Closing the above with the recommended workflow.