Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
270 stars 75 forks source link

[Combobox] Append custom values to top of Combobox dropdown, not bottom #7288

Open macandcheese opened 1 year ago

macandcheese commented 1 year ago

Check existing issues

Description

Currently, when allow-custom-values is true and a user adds a custom value, it is appended to the bottom of the Combobox dropdown.

This can be confusing, as when presented alongside groups, it's not clear if the added value is part of the last group due to indentation:

Screen Shot 2023-07-06 at 11 12 58 AM

Acceptance Criteria

The appended items are added to the top

Relevant Info

There are probably additional desirable configurations - sometimes an app may want to add a created item to a specific group, or allow a user to remove an item they've created.

cc @ashetland @mitc7862

Which Component

Combobox

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

Esri team

Calcite (design)

github-actions[bot] commented 1 year ago

cc @geospatialem, @brittneytewks