search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
290 stars 75 forks source link

[Input Date Picker] In Firefox and Safari, numbering-system="latn" should change numbers in date header for "ar" to "latn" numbers #7383

Closed annierm18 closed 11 months ago

annierm18 commented 1 year ago

Check existing issues

Actual Behavior

The numbers in the date header (e.g. 7/26/2023) and the value in the input appear in "arab" numbers.

Expected Behavior

The numbers should appear in "latn" numbers. This is so that the component can be consistent with the default behavior for lang="ar" in Edge and Chrome.

Reproduction Sample

https://codepen.io/ainermfc/pen/XWyxRWw?editors=100

Reproduction Steps

  1. Open the input time picker in Firefox or Safari
  2. Set the dir to rtl (not necessary)
  3. Set lang="ar"
  4. Set numbering-system="latn"

Reproduction Version

1.4.3

Relevant Info

Calcite history related to this issue can be found in the comments of https://github.com/Esri/calcite-design-system/issues/3079, e.g https://github.com/Esri/calcite-design-system/issues/3079#issuecomment-1168964195

This is the part in the Calcite code which handles the browser default discrepancy: https://github.com/Esri/calcite-design-system/blob/8dcfbd1a2e23d7fe73c11ff64913c7c95e6a3a9f/packages/calcite-components/src/utils/locale.ts#L139-L142

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

Esri team

ArcGIS Urban

github-actions[bot] commented 11 months ago

Installed and assigned for verification.

DitwanP commented 11 months ago

🍬 Verified locally on main