Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
274 stars 75 forks source link

Chip/Chip Group selection icon padding #7425

Closed ashetland closed 1 week ago

ashetland commented 11 months ago

Check existing issues

Actual Behavior

When in selection-mode="single" | "single-persist", there are a few errors in padding around the selection icon.

Expected Behavior

See this Figma file for the correct padding.

Reproduction Sample

https://codepen.io/ashetland/pen/zYMLqyd?editors=1000

Reproduction Steps

  1. Open the codepen
  2. Note padding around the selection icon

Reproduction Version

1.4.3

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

Esri team

Calcite (design)

ashetland commented 2 months ago

Here's the design spec for this one https://www.figma.com/design/HB1Ollf1D1Csy2PtXJ3Hai/Chip-selection-affordance-%26-padding?node-id=501-15580&m=dev

This is also linked above.

Elijbet commented 1 week ago

Closing, as this was address with https://github.com/Esri/calcite-design-system/pull/9286