Calcite-panel missing display:flex on content-wrapper

JonUihlein commented 1 year ago

Check existing issues

[X] I have checked for existing issues to avoid duplicates

Actual Behavior

For JSAPI.

FeatureTable isn't appearing as expected when embedded in a simple calcite-panel: https://codepen.io/jonuihlein/pen/wvQOqeO?editors=1000

Background:

Originally reported from Map Viewer team, but reproducible with simple sample above.

It looks like in there was an internal "content" node inside calcite-panel that had the content-container class removed (there in 1.4.2) which was responsible for setting the content height to 100%.

I feel like we went through something similar when Editor was using calcite-panel over calcite-flow but were able to ignore the issue as a result of switching over to flow. However, the above case has worked as expected in the map viewer up until this point so it is likely our users may run into this as well.

Spoke with @driskull and he identified that "content-wrapper" is missing display: flex.

Expected Behavior

content node should have display: flex;

Reproduction Sample

https://codepen.io/jonuihlein/pen/wvQOqeO?editors=1000

Reproduction Steps

Open sample, table does not appear as expected. Change version to 1.4.2, table appears.

Reproduction Version

1.5.0

Relevant Info

No response

Regression?

1.4.3

Priority impact

p1 - need for current milestone

Impact

FeatureTable does not work in AGOL Map Viewer

Calcite package

[X] @esri/calcite-components
[ ] @esri/calcite-components-react

Esri team

ArcGIS Maps SDK for JavaScript

subgan82 commented 1 year ago

Please add ArcGIS charts project as well to the issue labels we are impacted by it , is there a CSS workaround ? https://devtopia.esri.com/WebGIS/arcgis-charts/issues/6348