search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
285 stars 76 forks source link

Audit non-component event targets and update conventions #7468

Open jcfranco opened 1 year ago

jcfranco commented 1 year ago

Description

@Listen and custom events use document.body, document or window as targets/dispatchers. We should audit and update our conventions with information regarding the appropriate target to use per context.

Proposed Advantages

Consistent target/dispatching for non-component events.

Which Component

All components dispatching/listening events on document or document.body and possibly window.

Relevant Info

Stems from https://github.com/Esri/calcite-design-system/pull/7466#discussion_r1284921350

Calcite package

geospatialem commented 4 months ago

Refer to Matt's PR with color-picker, popover, etc. to accommodate iframes: https://github.com/Esri/calcite-design-system/pull/8247