Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
285 stars 76 forks source link

Borders inconsistent when list comprises both grouped and ungrouped list items #7546

Closed nwhittaker closed 10 months ago

nwhittaker commented 1 year ago

Check existing issues

Actual Behavior

Given a list containing a mix of list items and grouped list items:

  1. A border does not appear before an item if the previous item is in a group.
  2. A border does appear before a group heading if the previous item is not in a group.
Screenshot 2023-08-17 at 4 16 46 PM

Expected Behavior

I expected borders to behave as they do in non-hybrid lists:

  1. A border always appears before an item unless it's the first item.
  2. A border never appears before a group heading.

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/LYMYpGj

Reproduction Steps

  1. Visit reproduction sample
  2. Verify no border appears between the Waterfalls and Rivers items
  3. Verify a border appears before the Building group header

Reproduction Version

1.6.0

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

Esri team

ArcGIS Field Apps

github-actions[bot] commented 10 months ago

Installed and assigned for verification.

geospatialem commented 10 months ago

Verified on the main branch:
image

nwhittaker commented 10 months ago

@geospatialem, I updated the repro sample to 1.11.0. I see the border is gone from above the Buildings header, but I don't see a border between the Waterfalls and Rivers list items. Fair enough if this is the expected design, but I wanted to double-check…

Screenshot 2023-11-27 at 10 27 01 AM
anveshmekala commented 10 months ago

@geospatialem, I updated the repro sample to 1.11.0. I see the border is gone from above the Buildings header, but I don't see a border between the Waterfalls and Rivers list items. Fair enough if this is the expected design, but I wanted to double-check…

Hi @nwhittaker , the border between list-item in a group and other list-item should be present (In this case Waterfalls and Rivers). This is a bug and will fix it. Thanks for reporting.

github-actions[bot] commented 10 months ago

Installed and assigned for verification.

anveshmekala commented 10 months ago

Hi @nwhittaker , the fix is installed in 1.11.1-next.2. Could you please verify if it is working as expected? Thank you.

nwhittaker commented 10 months ago

Hi @nwhittaker , the fix is installed in 1.11.1-next.2. Could you please verify if it is working as expected? Thank you.

@anveshmekala, I forked a new code sample and updated it to 1.11.1-next.2 and it looks good to me, thanks!

geospatialem commented 10 months ago

Closing per the verification above, also confirmed in 1.12.0-next.6. 🎉