Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
282 stars 76 forks source link

Color Picker's alpha-channel slider scope doesn't update #7761

Closed ashetland closed 7 months ago

ashetland commented 1 year ago

Check existing issues

Actual Behavior

When using the alpha-channel slider, the scope doesn't update to reflect the current opacity. CleanShot 2023-09-18 at 13 10 09

Expected Behavior

I would expect the color in the scope to change. image

Reproduction Sample

https://developers.arcgis.com/calcite-design-system/components/color-picker/

Reproduction Steps

  1. Enable alpha-channel
  2. Use alpha-channel slider

Reproduction Version

v1.8.0

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

Esri team

Calcite (design)

github-actions[bot] commented 7 months ago

Installed and assigned for verification.

ashetland commented 7 months ago

Hey team, I think I expected the color in the alpha channel scope to fade out to white like pictured above instead of being completely transparent.

geospatialem commented 7 months ago

Hey team, I think I expected the color in the alpha channel scope to fade out to white like pictured above instead of being completely transparent.

@Elijbet - can you confirm on @ashetland's comment above? It looks like the scope (where the pointer is the below screenshot) differs from the expected behavior.

Expected

image

With 2.5.0-next.2

image

jcfranco commented 7 months ago

@ashetland @geospatialem IMO, the current behavior is expected since the checkerboard pattern is being used to represent full transparency.

This is common in other color picker components:

https://uiwjs.github.io/react-color/ https://jscolor.com/ https://opensource.adobe.com/spectrum-web-components/components/color-area/ 👇

Screenshot 2024-02-14 at 10 44 55 AM
ashetland commented 7 months ago

Yeah definitely see this both out in the wild. Even your first example shows both approaches next to each other😆. If the current setup feels more Calcite-y, then happy to go with this and update in the future if folks voice opinions.

ashetland commented 7 months ago

Even your first example shows both approaches next to each other😆.

Scratch that, the one on the right doesn't have color in the thumbs at all 🤦‍♂️.

geospatialem commented 7 months ago

Marking as verified per on the conversation above in https://github.com/Esri/calcite-design-system/issues/7761#issuecomment-1944409876 and https://github.com/Esri/calcite-design-system/issues/7761#issuecomment-1944425756.