search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
280 stars 76 forks source link

[Combobox Item] `--calcite-ui-icon-color` CSS Property does not work #7854

Open macandcheese opened 11 months ago

macandcheese commented 11 months ago

Check existing issues

Actual Behavior

Using --calcite-ui-icon-color CSS Property does not work for Combobox Item.

Expected Behavior

I'd expect the override to take effect, as it does in other components.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/abPEvMQ?editors=1000

Reproduction Steps

  1. Open Codepen
  2. Notice the override works for Dropdown
  3. Notice the override does not work for Dropdown.

Reproduction Version

1.8

Relevant Info

No response

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

While expanding the available public css properties through the design token effort will make overriding icon colors easier (especially since we'll have values for individual icons like selection icon + the icon set via property) - this variable should still work.

Calcite package

Esri team

Calcite (design)

geospatialem commented 10 months ago

Should be included in the screenshot test stories by adding a combobox with an icon.

geospatialem commented 5 months ago

We should check if this is mitigated by efforts in https://github.com/Esri/calcite-design-system/issues/7180 once completed.