Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
285 stars 76 forks source link

[Table] Rename `zebra` property to `striped` #7906

Closed macandcheese closed 9 months ago

macandcheese commented 1 year ago

Description

This one slipped under the radar during build and review. We should probably use striped instead of zebra to better align with bordered nomenclature

Proposed Advantages

Consistency of property name / tense.

Which Component

Table

Relevant Info

Deprecate zebra and add support for striped - remove support for zebra next breaking change release.

Calcite package

driskull commented 1 year ago

👋 🦓

jcfranco commented 1 year ago

Deprecate zebra and add support for striped - remove support for zebra next breaking change release.

If we're deprecating, we can remove the breaking changes label. From what I can tell, there only zebra-related style is this one, so we could keep it until the next, next breaking changes release. Current one is planned for November.

How likely is zebra to be used in current, supported use cases? I'm guessing it's quite common. 🦓

macandcheese commented 1 year ago

@jcfranco - yeah, feel free to update, we can add striped, deprecate zebra, and remove it ... later ™️

github-actions[bot] commented 9 months ago

Installed and assigned for verification.

geospatialem commented 9 months ago

Verified on the main branch with the striped attribute. Also, the zebra attribute is still working to ensure deprecation/support. 🎉