search

Esri / calcite-design-system

A monorepo containing the packages for Esri's Calcite Design System
https://developers.arcgis.com/calcite-design-system/
Other
285 stars 76 forks source link

Refactor: remove `ref should be last node` comments, made redundant by the new custom ESLint rule #7976

Closed Elijbet closed 11 months ago

Elijbet commented 11 months ago

Description

Related Issue: #7659

Remove ref should be last so node comments, made redundant by the new custom ESLint rule.

Proposed Advantages

The new rule removes the need to disable the ESLint rule enforcing alphabetical ordering by the following comment:
// eslint-disable-next-line react/jsx-sort-props -- ref should be last so node attrs/props are in sync

Which Component

All

Relevant Info

No response

Calcite package

Elijbet commented 11 months ago

Looks like we won't be having a solution where the explainer is not needed anymore. So we can close this. chore: add a fixer to custom ESLint rule to place ref last along with the ignore doc line and explainer #8080